Per tickets such as T183901, T191104 etc, it was agreed to reword
Save to Publish on public wikis. Mobile sites are also included hence
this change.

The button to write edits to database on mobile sites is now labeled
"Publish" and the flash on success also uses the word "published" in
its text.

Bug: T191104
Change-Id: I6f6c7c139335f8b126630f31d064eb33b9393098

As implemented onBeforeExit only runs if you click on the close icon.
This change ensures we keep backwards compatibility with the editor
overlay and ensure users of the onBeforeExit function will continue
to work. The editor will need to make use of onBeforeExit to enjoy
the same functionality (I2668b6e54a6d54e820d60e4b56028338908ad55f)

Additional changes:
* force parameter is no longer a parameter to hide. It doesn't seem
to be used. Test is updated accordingly

Bug: T218173
Change-Id: Ife5ccf7a4a55efab64ef528b7aa28b963d195674

Bug: T217296
Change-Id: I9313528fca89d6b073aefcfdde9781ef5719b5e1

Apply 'mobile edit' and 'mobile web edit' if applicable to all log
entries. MobileFrontend will apply tags to all log entries only
when user is browsing Wikipedia in the mobile mode.

Bug: T215477
Change-Id: I3037171e6ba3ec5cbf05cc5a6e0df251f290377f

If user enabled the 'Advanced Mobile Contributions' mode we would
like to tag all log entries with the 'advanced mobile edit' tag.

Bug: T215477
Depends-On: Ia4c019db8ca6f37ce0f86bf7d134d6f1713daf56
Depends-On: I747eded4bc5406cd5d4676fc93b0bb55c99f9a4d
Change-Id: Idb8d92c14524caa16b484855d6095205168909ff

Having them in a single container allows us to distinguish overlays
created outside the overlayManager (e.g. loadingOverlay)
from ones managed by the overlay (e.g. editor). This is helpful when
integrating with browser history as needed in T218173

The function signature for OverlayManager is changed. Given there
are no consumers in Wikimedia projects, this is not a problem.

Additional change:
* Replace a jQuery selector with a jQuery generated tag and drop
global jQuery usage

Bug: T218173
Change-Id: If4d4009a3f87b5c40ed966871659135e4fd76473

In future this talk overlay will be a standard overlay with a talk
topic form component inside it. While the template will be removed
shortly as part of this factory this sets the direction and makes sure
the CSS is ready.

Bug: T217102
Change-Id: I58e5b3ad61871d456e6b26de3d9027809b11df2e

Change-Id: I03a11bd9668a911089a1ae134de726dc53ce40b8

Bug: T217102
Change-Id: Id2993dbaa69ea8df0db922453f1bbfed91c3d9ee

No longer a thing since Ie86067c6f81deebfd85efbb9537519ad7179f5a4

Bug: T217102
Change-Id: I13ca0d468cb92ef0c6a61a54a0a6b33d0fe8d55c

This is a `dumb` presentational component that merely presents details
about an image including the author, license link, details link, and
caption. It only has rendering logic.

This will be used by image carousel in
I549add34101d58439b25265473a3a611c3324154. In the meantime, the current
ImageOverlay will use its styles found in imageDetails.less.

Additional changes:

* The fixme instructing to merge with overlay-footer-container was removed

* ImageOverlay.hogan was modifed to use image-details styles

* ImageOverlay.js was modified to use image-details styles

* .animations .media-viewer .details was removed from mediaViewer.less.
This transition is assumed safe to remove because opacity isn't even a
property of .details (now .image-details)!

* extension.json was modified to use imageDetails.less

* ImageOverlay.test.js was fixed to support .image-details

Bug: T216198
Change-Id: Ia227186ccc1d8200e8357ea411358347f5b4339b

Change-Id: I1493097f6381a534ddd9315f91f1f01678cfb4e0

Follow-up to 6d045d0f.

Change-Id: I684a7dfb8bac883bd1cc14e82c93554acb886c75

This code became unused in I846c0b3013074883ee39d225ed083de03fc6b0c7
The behaviour will be reconsidered in
https://phabricator.wikimedia.org/T218415 but should be removed for
now to give us a clean slate rather than code based on iOS 4 and 5.

Change-Id: I60585564a6c537417d1dd1badd471e1c47f92720

Change-Id: I818c6976a812f57b5c7a2251857ab9d4a16eac40

Textarea rules are already defined for panels
(See I8c34646b7ba13a26facbb69684e65109870d27a1)

Bug: T217102
Change-Id: I1b69c6eedece163436c8d868f2b64872e79e55cf

iOS 4 and 5 account for less than 0.5% of our traffic
iOS 9 is 0.47%!

Thus remove these hacks.

Link: https://analytics.wikimedia.org/dashboards/browsers/#all-sites-by-os/os-family-and-major-hierarchical-view
Change-Id: I7b86f17e3eb8669a46bf00cc9f247afb0032bd80

I'm not sure what the history of the EditorOverlay scroll
onWindowScroll function is, but it seems to be in direct
conflict with the scrolling hacks disabled
in I846c0b3013074883ee39d225ed083de03fc6b0c7

After removing this code the editor appears to become usable
again. This is a great example of why the inheritance pattern is bad.
It adds lots of indirection and confusion.

Bug: T218062
Bug: T218352
Bug: T211490
Bug: T218062
Bug: T211491
Bug: T172877
Change-Id: I0781a2d1d8252c8c8004f0e8ab67705978ae3c18

Change-Id: Ib786d546782d97fa042b0797cec60dab06455a08

We would like to thoroughly test on the beta cluster what the impact of
disabling iOS emulation is. Due to having issues with local environments
this is the quickest way to get the widest possible amount of testers
identifying what the iOS scroll emulation is for.

Change-Id: I846c0b3013074883ee39d225ed083de03fc6b0c7

The editor seems to be the only overlay in need of this so I
think we should disable this behaviour by default. This restores
the correct scrolling behaviour for the add discussion overlay.

It also separates the concerns more cleanly for scrolling emulation.

Bug: T218069
Change-Id: If247cee79640e0bbc997feb32fbca4770183a78c

These changes were made:

* props.featured was thrown out in favor of displaying the item at
props.items[props.index].

* If props.items[prop.index] is a View, carousel will now recognize that
and render its $el property. If it is not a View, carousel will pass it
straight to JQuery's append method. Carousel should not mandate that
props.items be an array of Views because it might be desirable to have
the item you want to currently display different from the rest of the
items in the array. An example of this is by imageCarousel in
Ibd1cbc6bad2d7d3cf9fffb5e40001e107e7f3333 which will pass Carousel an
array of async functions but props.items[prop.index] will be a View
(from promisedImage).

* Tried to improving wording of jsdoc.

Bug: T216198
Change-Id: I190efb31fa5c0c8308ec880fe2ed04a61ff2af83

Not stubbing this was causing problems in Special:JavaScript/qunit
_distanceMessage can be called inside _search as well!

Note, we don't load the associated messages in the Special page
so stubbing is important! jQuery msg was trying to find a $1 in
the key mobile-frontend-nearby-distance-meters

Bug: T218172
Change-Id: Ib2b34abff218fc67d1e2b5308928bbf64e1b91fb

These variables are not used outside the scope of this function

Bug: T217296
Change-Id: I815892260bec1f987b80e386fe5a7a0941c887f6

Do not extend class properties where parameters can be passed in

This cleans up the NotificationsOverlay a little by making use of
headerActions, footerActions and heading rather than changing those
properties via preRender and default extending

Bug: T217296
Change-Id: I31c86350c31d835fb92a3d74ad4c8aa7e663dc9e

Often we'll be wanting to turn lots of jQuery elements into View.
This helper will make that easier.

It's first usage will be in I815892260bec1f987b80e386fe5a7a0941c887f6

Bug: T217296
Change-Id: Ifd438dd82550930710b18ce4a4e89b413b25a5a3

This rule is overriden by .overlay button and even with that rule
removed, this has no impact on the visual display due to the min-width
of 60px which is larger than this width!

Change-Id: I0dd6e4bfaed97a12e1f99ac469edc037eb831675

This is a `dumb` presentational component accepting an arbitrary array
of items that a user should presumably be able to navigate through and a
featured item that is currently on display. When the user clicks one of
the navigation arrows, the onSlide callback will give you the next item
as a param! This component does nothing with the actual changing of
items - that is left up to other components.

This component will be used in I549add34101d58439b25265473a3a611c3324154
to display the image carousel. In the meantime, its .slider-button
styles will be applied to ImageOverlay (previously in Overlay.less).

Bug: T216198
Change-Id: Icce158581be7e29d6a1991815061cba634a56056