Skip to content
GitLab
    • Explore Projects Groups Snippets
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • 2 2006Scape
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 26
    • Issues 26
    • List
    • Boards
    • Service Desk
    • Milestones
    • Requirements
  • Merge requests 4
    • Merge requests 4
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Dark98
  • 2006Scape
  • Merge requests
  • !473

Fix bug where leveling up while Smelting would consume ores.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Dark98 requested to merge gh-fdfcb80b/473/unknown/refs/pull/473/head into master 4 years ago
  • Overview 0
  • Commits 2
  • Pipelines 0
  • Changes 2

Smelting doesn't stop when you level up. As it continues smelting you lose ores but do not gain bars.

Step to reproduce

::tp 2973 3370
::skill 13 1
::empty
::item 436 10
::item 438 10
// smelt 10, get 10 bars
::empty
::item 436 10
::item 438 10
// smelt 10 again, it will level up, keep smelting, removing ore but not giving bars

Problem

Leveling up will clear isSmelting preventing bars for being given but not hitting a condition to break out of the smelting loop.

Fix

Utilize resetSmelting which, in addition to clearing isSmelting will cause it to end the smelting at one of these checks: https://github.com/2006rebotted/2006rebotted/blob/fa167bacd3999efda6c7dff6d3d357cdb0731064/2006Redone%20Server/src/main/java/com/rebotted/game/content/skills/smithing/Smelting.java#L158-L165

Additionally, giving the item before the xp ensures that you receive the bar that levels you up.

Activity

Please register or sign in to reply
0 Assignees
None
Assign to
0 Reviewers
Request review from
Labels
0
None
0
None
    Assign labels
  • Manage project labels

Milestone
No milestone
None
None
Time tracking
Lock merge request
Unlocked
participants
Reference:
Source branch: gh-fdfcb80b/473/unknown/refs/pull/473/head

Menu

Explore Projects Groups Snippets